Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MapMonitoredResource field to Log config. #826

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

aglipska
Copy link
Contributor

It is needed for users that want to use their own logs resource mapping method because their resource is not mapped in community.

aglipska and others added 3 commits March 27, 2024 17:12
Co-authored-by: David Ashpole <dashpole@google.com>
Signed-off-by: aglipska <107988284+aglipska@users.noreply.github.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.10%. Comparing base (e307cf7) to head (cc746be).

Files Patch % Lines
exporter/collector/logs.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   61.03%   61.10%   +0.07%     
==========================================
  Files          56       56              
  Lines        5902     5903       +1     
==========================================
+ Hits         3602     3607       +5     
+ Misses       2143     2139       -4     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole
Copy link
Contributor

/gcbrun

@aglipska aglipska marked this pull request as ready for review March 27, 2024 18:04
@aglipska aglipska requested a review from a team as a code owner March 27, 2024 18:04
@dashpole dashpole merged commit 4caace7 into GoogleCloudPlatform:main Mar 27, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants