Add pass through of status message #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
approved these changes
Aug 11, 2020
| sp.Status = &statuspb.Status{Code: int32(s.StatusCode), Message: s.StatusMessage} | ||
| } | ||
| if s.StatusCode == codes.OK && s.StatusMessage != "" { | ||
| sp.Status = &statuspb.Status{Code: int32(s.StatusCode), Message: s.StatusMessage} |
There was a problem hiding this comment.
Can this just be one condition to avoid the duplicated code:
if s.StatusCode != codes.OK || s.StatusMessage != "" {
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the the status of a span with
span.SetStatus(codes.Unknown, "Error message"), the error message didn't get send to the server. This PR adds the status message to the grpc request if a message is given.