Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc example to allow long runs #835

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Apr 18, 2024

Updates the sample to add a --keepRunning flag that runs the sample program for 2 hours, generating a test span every 10 seconds. A successful run of this sample would verify that the per rpc credentials refresh is working as expected with the otlpgrpctraceexporter.

Testing

  • go run example.go
  • go run example.go --keepRunning

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.02%. Comparing base (4caace7) to head (c12f361).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   61.03%   62.02%   +0.98%     
==========================================
  Files          56       56              
  Lines        5903     4850    -1053     
==========================================
- Hits         3603     3008     -595     
+ Misses       2143     1685     -458     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psx95 psx95 marked this pull request as ready for review April 18, 2024 23:36
@psx95 psx95 requested a review from a team as a code owner April 18, 2024 23:36
@psx95 psx95 requested review from damemi and dashpole April 18, 2024 23:36
example/trace/otlpgrpc/example.go Show resolved Hide resolved
@psx95 psx95 merged commit 4fe07d3 into GoogleCloudPlatform:main Apr 19, 2024
32 checks passed
@psx95 psx95 deleted the otlp-grpc-token-refresh branch April 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants