feat: simplify logging in instrumentation quickstart #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
simplify_logging
branch
from
10f8ac2
to
10cbe15
Compare
psx95
reviewed
Feb 28, 2024
| @@ -21,7 +21,6 @@ services: | |||
| - OTEL_EXPORTER_OTLP_ENDPOINT=http://otelcol:4317 | |||
| - OTEL_SERVICE_NAME=otel-quickstart-spring-boot | |||
| - OTEL_METRIC_EXPORT_INTERVAL=5000 | |||
| - GOOGLE_CLOUD_PROJECT | |||
There was a problem hiding this comment.
Interesting - was this not supposed to have a value ?
There was a problem hiding this comment.
not sure. Maybe it implicitly means "pass through the GOOGLE_CLOUD_PROJECT env var"?
psx95
approved these changes
Feb 28, 2024
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Apr 17, 2024
…rces-support to v0.28.0 (#2649) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud.opentelemetry:detector-resources-support](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java) | `0.27.0` -> `0.28.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>GoogleCloudPlatform/opentelemetry-operations-java (com.google.cloud.opentelemetry:detector-resources-support)</summary> ### [`v0.28.0`](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/releases/tag/v0.28.0) [Compare Source](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/compare/v0.27.0...v0.28.0) #### Release Highlights - Add support for `CreateServiceTimeseries` in metrics exporter in [#​318](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/318). - Add resource attributes as metrics labels by providing a Predicate based filter to control which resource attributes end up as metric labels in [#​314](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/314), [#​319](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/319). #### What's Changed - Add Readme for detector-resources-support module by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#282 - Copy instrumentation quickstart out of java-docs-samples by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#283 - Enable snippet-bot by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#284 - Quota project fix by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#286 - Use logstash-logback-encoder version that works with spring boot 2 by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#285 - Update instrumentation quickstart README links by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#287 - Make examples/instrumentation-quickstart a standalone gradle build by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#289 - Add CI for examples/instrumentation-quickstart by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#290 - Test against java 11 by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#293 - Update TraceTranslator.java by [@​WadeGulbrandsen](https://togithub.com/WadeGulbrandsen) in [GoogleCloudPlatform/opentelemetry-operations-java#296 - feat: simplify logging in instrumentation quickstart by [@​dashpole](https://togithub.com/dashpole) in [GoogleCloudPlatform/opentelemetry-operations-java#298 - Update Gradle to v8.6 by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#300 - Replace resource detector with upstream detector by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#301 - Update links to the upstream detector by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#302 - Add OTLP trace with ADC example by [@​damemi](https://togithub.com/damemi) in [GoogleCloudPlatform/opentelemetry-operations-java#297 - Update auto-exporter readme by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#304 - Add tests to verify OTel integration using in-memory exporter by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#306 - Add GH action step to test shadowJar by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#309 - Add missing GOOGLE_CLOUD_QUOTA_PROJECT environment variable to compose file by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#311 - Update instrumentation quickstart to new region tag name by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#312 - Update instrumentation-quickstart README by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#315 - Add resource attributes as metric labels by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#314 - Update resource detection sample by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#317 - Make setResourceAttributesFilter public by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#319 - Add support for createServiceTimeSeries by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#318 - Disable release for gcp-resource-detector by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#321 #### New Contributors - [@​WadeGulbrandsen](https://togithub.com/WadeGulbrandsen) made their first contribution in [GoogleCloudPlatform/opentelemetry-operations-java#296 - [@​damemi](https://togithub.com/damemi) made their first contribution in [GoogleCloudPlatform/opentelemetry-operations-java#297 **Full Changelog**: GoogleCloudPlatform/opentelemetry-operations-java@v0.27.0...v0.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as GoogleCloudPlatform/golang-samples#3801
Tested manually