chore: fix lint warnings

GoogleCloudPlatform · Sep 22, 2021 · 4299836 · 4299836
1 parent e1695df
commit 4299836
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 7 deletions.
diff --git a/e2e-test-server/src/index.ts b/e2e-test-server/src/index.ts
@@ -71,15 +71,15 @@ async function pubSubPull(): Promise<void> {
         headers: message.attributes,
         testId,
       });
-    } catch (e: any) {
+    } catch (e) {
       logger.error(
         'caught error from handler for scenario %s: %s',
         scenario,
         e
       );
       res = {
         statusCode: Status.INTERNAL,
-        data: Buffer.from(e?.stack ?? String(e)),
+        data: Buffer.from((e as Error | undefined)?.stack ?? String(e)),
       };
     } finally {
       if (res! === undefined) {

diff --git a/packages/opentelemetry-cloud-monitoring-exporter/src/monitoring.ts b/packages/opentelemetry-cloud-monitoring-exporter/src/monitoring.ts
@@ -145,7 +145,8 @@ export class MetricExporter implements IMetricExporter {
     )) {
       try {
         await this._sendTimeSeries(batchedTimeSeries);
-      } catch (err: any) {
+      } catch (e) {
+        const err = asError(e);
         err.message = `Send TimeSeries failed: ${err.message}`;
         failure = {sendFailed: true, error: err};
         diag.error(err.message);
@@ -222,8 +223,9 @@ export class MetricExporter implements IMetricExporter {
           }
         );
       });
-    } catch (err: any) {
-      diag.error(`MetricExporter: Failed to write data: ${err.message}`);
+    } catch (e) {
+      const err = asError(e);
+      diag.error('MetricExporter: Failed to write data: %s', err.message);
     }
   }
 
@@ -258,3 +260,10 @@ export class MetricExporter implements IMetricExporter {
     return (await this._auth.getClient()) as JWT;
   }
 }
+
+function asError(error: unknown): Error {
+  if (error instanceof Error) {
+    return error;
+  }
+  return new Error(String(error));
+}
diff --git a/packages/opentelemetry-cloud-trace-exporter/src/trace.ts b/packages/opentelemetry-cloud-trace-exporter/src/trace.ts
@@ -91,7 +91,8 @@ export class TraceExporter implements SpanExporter {
     diag.debug('Google Cloud Trace batch writing traces');
     try {
       this._traceServiceClient = await this._getClient();
-    } catch (error: any) {
+    } catch (e) {
+      const error = asError(e);
       error.message = `failed to create client: ${error.message}`;
       diag.error(error.message);
       return {code: ExportResultCode.FAILED, error};
@@ -106,7 +107,8 @@ export class TraceExporter implements SpanExporter {
       await batchWriteSpans(spans, metadata);
       diag.debug('batchWriteSpans successfully');
       return {code: ExportResultCode.SUCCESS};
-    } catch (error: any) {
+    } catch (e) {
+      const error = asError(e);
       error.message = `batchWriteSpans error: ${error.message}`;
       diag.error(error.message);
       return {code: ExportResultCode.FAILED, error};
@@ -146,3 +148,10 @@ export class TraceExporter implements SpanExporter {
     );
   }
 }
+
+function asError(error: unknown): Error {
+  if (error instanceof Error) {
+    return error;
+  }
+  return new Error(String(error));
+}