-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add optional filter for OTel resource attributes #361
feat: add optional filter for OTel resource attributes #361
Conversation
very excited to see this go through! |
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 95.48% 95.56% +0.07%
==========================================
Files 12 12
Lines 421 428 +7
Branches 80 81 +1
==========================================
+ Hits 402 409 +7
Misses 19 19
Continue to review full report at Codecov.
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and apologies for not looking sooner. LGTM, just a few nits
packages/opentelemetry-cloud-trace-exporter/test/transform.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Thanks for the review @aabmass! |
I fixed the lint so it should be good to go once the tests pass. Thanks for your contribution! |
👍 great job everyone! very excited to work this into my projects |
@aabmass question. when does the team usually cut a change to the package? I can clone the repo and get the changes, but curious when there is an official cut. |
We don't have a regular cadence, but I'll try to cut a release sooner than later. Depends on how long some of the other updates take. |
This is released in 1.1.0 |
@aabmass thank you! the minute you closed the PR I started working it into our microservices and I'm showing it to the engineering team in about an hour. This makes our work with tracing so much easier to use. |
Fixes #347
This PR adds support for exporting OpenTelemetry resource attributes that match a regular expression, as was suggested in the linked issue.