Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(monitoring-exporter): add snapshot tests for all instruments #449

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Nov 19, 2022

Testing with ints and floats as well.

@aabmass aabmass changed the title more snapshots test(monitoring-exporter): add snapshot tests for all instruments Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@700a106). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7e977bf differs from pull request most recent head 83e65a1. Consider uploading reports for the commit 83e65a1 to get more accurate results

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage        ?   93.27%           
=======================================
  Files           ?       12           
  Lines           ?      446           
  Branches        ?       87           
=======================================
  Hits            ?      416           
  Misses          ?       30           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass force-pushed the more-snapshots branch 4 times, most recently from 3c07742 to 2c18dcc Compare November 21, 2022 21:43
@aabmass aabmass marked this pull request as ready for review November 21, 2022 21:44
@aabmass aabmass requested a review from a team November 21, 2022 21:44
@aabmass aabmass enabled auto-merge (squash) November 22, 2022 23:08
@aabmass aabmass merged commit 51b3c59 into GoogleCloudPlatform:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants