Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitoring-exporter): add LabelDescriptors to metric descriptor #462

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 1, 2022

Includes normalizing label keys so they properly work with Cloud Monitoring.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #462 (8666f9c) into main (04404fe) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   94.80%   94.92%   +0.12%     
==========================================
  Files          13       13              
  Lines         462      473      +11     
  Branches       89       91       +2     
==========================================
+ Hits          438      449      +11     
  Misses         24       24              
Impacted Files Coverage Δ
...lemetry-cloud-monitoring-exporter/src/transform.ts 80.48% <100.00%> (+3.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass requested a review from a team December 1, 2022 22:33
@aabmass aabmass marked this pull request as ready for review December 1, 2022 22:33
@aabmass aabmass merged commit 54e8ca4 into GoogleCloudPlatform:main Dec 2, 2022
@aabmass aabmass deleted the normalize-labels branch December 2, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants