Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement /detectResource e2e scenario #468

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 10, 2022

Implement /detectResource e2e scenario with envDetector + our local resource detector. Tests are passing :)

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@88be17e). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 7a2628a differs from pull request most recent head e02a272. Consider uploading reports for the commit e02a272 to get more accurate results

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage        ?   95.60%           
=======================================
  Files           ?       16           
  Lines           ?      546           
  Branches        ?      101           
=======================================
  Hits            ?      522           
  Misses          ?       24           
  Partials        ?        0           
Impacted Files Coverage Δ
...entelemetry-resource-util/src/detector/detector.ts 100.00% <100.00%> (ø)
...es/opentelemetry-resource-util/src/detector/gce.ts 100.00% <100.00%> (ø)
...es/opentelemetry-resource-util/src/detector/gke.ts 100.00% <100.00%> (ø)
packages/opentelemetry-resource-util/src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass changed the title detect resource e2e feat: implement /detectResource e2e scenario Dec 10, 2022
@aabmass aabmass marked this pull request as ready for review December 14, 2022 16:04
@aabmass aabmass requested a review from a team December 14, 2022 16:04
@aabmass aabmass enabled auto-merge (squash) December 14, 2022 16:05
@aabmass aabmass merged commit 002b61a into GoogleCloudPlatform:main Dec 14, 2022
@aabmass aabmass deleted the detect-resource-e2e branch December 14, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants