Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix e2e Dockerfile build issue #484

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 23, 2022

Was failing because it was a different lerna version than specified in the package.json. Running npm install before npx lerna ... makes it use the locally installed version. # Please enter the commit message for your changes. Lines starting

@aabmass aabmass requested a review from a team December 23, 2022 00:58
@aabmass aabmass force-pushed the fix-e2e-build branch 2 times, most recently from 330adc4 to 83bf294 Compare December 23, 2022 01:02
Was failing because it was a different lerna version than specified in the `package.json`. Running `npm install` before `npx lerna ...` makes it use the locally installed version. # Please enter the commit message for your changes. Lines starting
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #484 (98c491e) into main (deffda0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          16       16           
  Lines         551      551           
  Branches      103      103           
=======================================
  Hits          527      527           
  Misses         24       24           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass enabled auto-merge (squash) December 23, 2022 02:21
@aabmass aabmass merged commit 51d0807 into GoogleCloudPlatform:main Jan 3, 2023
@aabmass aabmass deleted the fix-e2e-build branch January 4, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants