Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simplify Dockerfile with fewer steps to speed up build #500

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Jan 11, 2023

I originally had more steps to encourage cache hits, but this isn't working correctly in Cloud Build anyway. Fewer steps speed up the build.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #500 (d3579df) into main (b277b57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files          17       17           
  Lines         602      602           
  Branches      113      113           
=======================================
  Hits          577      577           
  Misses         25       25           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass marked this pull request as ready for review January 11, 2023 17:47
@aabmass aabmass requested a review from a team January 11, 2023 17:47
@aabmass aabmass enabled auto-merge (squash) January 11, 2023 17:47
I originally had more steps to encourage cache hits, but this isn't working correctly in Cloud Build anyway. Fewer steps speed up the build.
@aabmass aabmass merged commit e4c84e9 into GoogleCloudPlatform:main Jan 11, 2023
@aabmass aabmass deleted the dockerfile-faster branch January 11, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants