Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource-util): add App Engine detector #510

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Jan 18, 2023

e2e tests passing in this PR

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #510 (8e05171) into main (9593cb9) will increase coverage by 0.12%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   95.84%   95.97%   +0.12%     
==========================================
  Files          17       18       +1     
  Lines         602      646      +44     
  Branches      113      117       +4     
==========================================
+ Hits          577      620      +43     
- Misses         25       26       +1     
Impacted Files Coverage Δ
...es/opentelemetry-resource-util/src/detector/gae.ts 96.66% <96.66%> (ø)
...entelemetry-resource-util/src/detector/detector.ts 100.00% <100.00%> (ø)
packages/opentelemetry-resource-util/src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass marked this pull request as ready for review January 18, 2023 18:09
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aabmass aabmass merged commit 6f3fa8b into GoogleCloudPlatform:main Jan 18, 2023
@aabmass aabmass deleted the detect-gae branch January 18, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants