Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): stop installing latest npm which doesn't support old nodejs versions #624

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Sep 21, 2023

This fixes the build which is currently broken because npm@latest (v10) doesn't work with anything older than Node 20

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #624 (907e41b) into main (f7d9d8d) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 907e41b differs from pull request most recent head 3256346. Consider uploading reports for the commit 3256346 to get more accurate results

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          18       18           
  Lines         691      691           
  Branches      127      127           
=======================================
  Hits          675      675           
  Misses         16       16           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass changed the title chore(build): remove npm installation from build steps chore(build): stop installing latest npm which doesn't support old nodejs versions Sep 21, 2023
@aabmass aabmass marked this pull request as ready for review September 21, 2023 17:52
@aabmass aabmass requested a review from a team as a code owner September 21, 2023 17:52
@aabmass aabmass enabled auto-merge (squash) September 21, 2023 17:52
@aabmass aabmass merged commit fbfdf7d into GoogleCloudPlatform:main Sep 21, 2023
16 checks passed
@aabmass aabmass deleted the fix-build branch September 21, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants