Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop python3.5 add python3.9 #123

Merged
merged 4 commits into from
Apr 6, 2021
Merged

drop python3.5 add python3.9 #123

merged 4 commits into from
Apr 6, 2021

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented Apr 6, 2021 •
edited

Fixes #120

@google-cla google-cla bot added the cla: yes label Apr 6, 2021
aabmass
aabmass commented Apr 6, 2021
View reviewed changes
.pylintrc
@@ -64,7 +64,8 @@ disable=missing-docstring,
wrong-import-order, # Leave this up to isort
bad-continuation, # Leave this up to black
line-too-long, # Leave this up to black
exec-used
exec-used,
duplicate-code
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried disabling this check at the file level, but pylint ignored it :( the duplicate code was tests which was duplicated was between separate unit tests

aabmass
aabmass commented Apr 6, 2021
View reviewed changes
dev-constraints.txt
@@ -2,5 +2,5 @@ black~=19.10b0
flake8~=3.8.3
isort~=4.3 # pinned for pylint
mypy~=0.800
pylint~=2.6.2
pylint~=2.7.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to be upgraded due to a bug with pylint and python3.9

@aabmass aabmass marked this pull request as ready for review April 6, 2021 19:09
@aabmass aabmass requested a review from a team April 6, 2021 19:09
tbarker25
tbarker25 approved these changes Apr 6, 2021
View reviewed changes
Copy link

@tbarker25 tbarker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aabmass aabmass merged commit 1e0310e into GoogleCloudPlatform:master Apr 6, 2021
@aabmass aabmass deleted the drop-py35 branch April 6, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbarker25 tbarker25 tbarker25 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop python3.5
2 participants
@aabmass @tbarker25