Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no container name behaviour #186

Merged
merged 5 commits into from
May 13, 2022
Merged

Update no container name behaviour #186

merged 5 commits into from
May 13, 2022

Conversation

munagekar
Copy link
Contributor

@munagekar
Copy link
Contributor Author

@aabmass @dashpole PTAL.

@munagekar munagekar changed the title Update/no container name behaviour Update no container name behaviour May 6, 2022
@dashpole
Copy link
Contributor

dashpole commented May 6, 2022

/gcbrun

@dashpole
Copy link
Contributor

dashpole commented May 6, 2022

This lgtm, but i'll let @aabmass approve

@munagekar
Copy link
Contributor Author

@aabmass Could you take a look ?

@munagekar
Copy link
Contributor Author

@dashpole @aabmass Sorry for the ping again. Just pinging in case my previous message went unnoticed.

@aabmass aabmass merged commit f66591e into GoogleCloudPlatform:main May 13, 2022
@munagekar munagekar deleted the update/no-container-name-behaviour branch May 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@munagekar @dashpole @aabmass