Update cloud monitoring exporter to work with opentelemetry 1.x #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
update-stable-metrics
branch
8 times, most recently
from
0433ed4
to
f62023f
Compare
aabmass
force-pushed
the
update-stable-metrics
branch
from
f62023f
to
f3be454
Compare
This was referenced Nov 7, 2022
dashpole
approved these changes
Nov 7, 2022
opentelemetry-exporter-gcp-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
This was referenced Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
Update the exporter to work with the stable 1.x metrics SDK mostly based on https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/tree/main/exporter/collector.
This was a pretty invasive change and I removed a lot of stuff that is no longer applicable. I left a few TODOS for things that need to be worked on like resource mapping.
I removed all of the tests as many of them are no longer applicable. I'm adding golden/snapshot tests in the next PR: #207