Implement resource detection e2e scenario #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
e2e-detect-resource
branch
16 times, most recently
from
4a43330
to
19dda4b
Compare
aabmass
changed the title
aabmass
force-pushed
the
e2e-detect-resource
branch
from
19dda4b
to
5d730f7
Compare
dashpole
reviewed
Feb 23, 2023
aabmass
force-pushed
the
e2e-detect-resource
branch
from
5d730f7
to
26e8a8e
Compare
dashpole
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is successfully detecting on GKE, GCE. Will add GCR and other serverless in follow up PRs.