Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of deprecated class BoundedDict with BoundedAttributes #238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace use of deprecated class BoundedDict with BoundedAttributes #238

wants to merge 3 commits into from
+7 −5

Conversation

shevisj
Copy link

@shevisj shevisj commented Apr 21, 2023 •
edited

Replace deprecated BoundedDict with BoundedAttributes and bump minimum version requirement of opentelemetry-api from 1.0 to 1.4 in opentelemetry-exporter-gcp-trace

Fixes #226

@google-cla
Copy link

google-cla bot commented Apr 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shevisj shevisj force-pushed the patch-1 branch 2 times, most recently from 56d2389 to f803ccf Compare April 21, 2023 20:59
@shevisj shevisj marked this pull request as ready for review April 21, 2023 21:01
@shevisj shevisj requested a review from a team as a code owner April 21, 2023 21:01
@shevisj shevisj requested a review from aabmass April 24, 2023 19:03
aabmass
aabmass approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for your contribution!

@aabmass
Copy link
Collaborator

aabmass commented Apr 24, 2023

/gcbrun

@aabmass aabmass enabled auto-merge (squash) April 24, 2023 19:09
@aabmass
Copy link
Collaborator

aabmass commented Apr 24, 2023

I'm fixing the CI in #239

aabmass
aabmass requested changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops forgot one thing–@shevisj would you mind adding a changelog entry for this?

@aabmass
Copy link
Collaborator

aabmass commented Apr 25, 2023 •
edited

/gcbrun

auto-merge was automatically disabled April 25, 2023 22:43

Head branch was pushed to by a user without write access

@shevisj shevisj requested a review from aabmass April 25, 2023 22:44
aabmass
aabmass approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@aabmass aabmass left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for contributing!

@aabmass aabmass enabled auto-merge (squash) April 25, 2023 23:07
@shevisj
Copy link
Author

shevisj commented Apr 25, 2023 •
edited

Hmm, unfortunately it looks like the BoundedAttributes class has tighter constraints on allowed attribute value types as compared with BoundedDict. I will work on getting my local dev env configured so that I can play around with it and can get tests to pass locally.

auto-merge was automatically disabled April 25, 2023 23:23

Head branch was pushed to by a user without write access

@shevisj shevisj force-pushed the patch-1 branch 2 times, most recently from 859b3ba to 4a18808 Compare April 25, 2023 23:26
@aabmass
Copy link
Collaborator

aabmass commented May 1, 2023

/gcbrun

@aabmass aabmass enabled auto-merge (squash) May 1, 2023 15:49
@aabmass
Copy link
Collaborator

aabmass commented Jul 17, 2023

@shevisj do you have any idea how to fix the issue or could update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BoundedDict was deprecated in opentelemetry-python 1.4.0
2 participants
@shevisj @aabmass