Add grpc trace export sample #316
Merged
+114
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
reviewed
May 1, 2024
psx95
force-pushed
the
add-grpc-trace-export
branch
from
5fae530
to
782094b
Compare
aabmass
reviewed
May 2, 2024
The default implementation was not working earlier because the x-goog-user-project was being set by the code as well as gRPC. Resulting in duplicating the header. This caused value of the project name to be repeated, resulting in a project ID that did not exist.
psx95
force-pushed
the
add-grpc-trace-export
branch
from
48137dd
to
72c4735
Compare
aabmass
approved these changes
May 2, 2024
|
Addressed all minor feedback in #321. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added gRPC sample also showcases credential refresh process.
Testing
python3 example_grpc.py