Add support for ValueObserver #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewAXue
commented
Jul 21, 2020
| @@ -44,6 +47,8 @@ | |||
|
|
|||
| # pylint is unable to resolve members of protobuf objects | |||
| # pylint: disable=no-member | |||
| # pylint: disable=too-many-branches | |||
There was a problem hiding this comment.
Temporarily added. This file is overdue for some cleaning up, will do that after to avoid having a PR with refactor + logic changes.
added 2 commits
July 21, 2020 11:47
cnnradams
approved these changes
Jul 21, 2020
opentelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
sjbrunst
approved these changes
Jul 21, 2020
opentelemetry-exporter-cloud-monitoring/tests/test_cloud_monitoring.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
LGTM!
Wondering why this aggregator wasn't set as the default for ValueRecorder as well., or maybe I'm misunderstanding open-telemetry/oteps#117
opentelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
…rter/cloud_monitoring/__init__.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>
The OT side of things is prolly just out of date, I imagine it'll be fixed soon (if not by me, someone else) since it's a fairly simple change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregation method that ValueObserver uses, ValueObserverAggregator was previously unsupported. After offline discussion with @aabmass and @cnnradams we agreed on a method of representing this info in Cloud Monitoring.
Resolves #18