Fix: Network Manager race condition #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avilevy-network-manager-fix
…o avilevy-network-manager-fix
avilevy18
requested review from
a team,
sophieyfang and
ridwanmsharif
and removed request for
a team and
sophieyfang
| response, err := http.Get(r.url) | ||
| var response *http.Response | ||
| var err error | ||
| for i := 0; i < 5; i++ { |
There was a problem hiding this comment.
Why did we need to do this 5 times if we're using systemd to make network-online a prerequisite target?
There was a problem hiding this comment.
I assume it's for error 5xx flakes but in that case a comment in the code is probably warranted
There was a problem hiding this comment.
If a machine has multiple network interfaces, network-online indicates that only one of them has come up so far.
Adding network-online.target is a best effort not a full solution.
|
This should refer to b/295772265 instead. |
avilevy18
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
quentinmit
approved these changes
Aug 28, 2023
avilevy18
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
avilevy18
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Health check were failing incorrectly on VM restart for some distros, this was caused by the Ops Agent main service starting up before the network service.
Related issue
b/295772265
How has this been tested?
Integration tests
Checklist: