-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Network Manager race condition #1376
Conversation
…o avilevy-network-manager-fix
…o avilevy-network-manager-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something we need to do in Windows to also avoid this race condition?
response, err := http.Get(r.url) | ||
var response *http.Response | ||
var err error | ||
for i := 0; i < 5; i++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to do this 5 times if we're using systemd to make network-online
a prerequisite target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it's for error 5xx flakes but in that case a comment in the code is probably warranted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a machine has multiple network interfaces, network-online
indicates that only one of them has come up so far.
Adding network-online.target
is a best effort not a full solution.
This should refer to b/295772265 instead. |
Description
Health check were failing incorrectly on VM restart for some distros, this was caused by the Ops Agent main service starting up before the network service.
Related issue
b/295772265
How has this been tested?
Integration tests
Checklist: