Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: add retries for Windows Core ssh issues #1514

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Testing: add retries for Windows Core ssh issues #1514

merged 4 commits into from
Nov 20, 2023

Conversation

martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Nov 14, 2023 •
edited

Description

This is a workaround for b/305721001.

Related issue

b/305721001

How has this been tested?

automated tests should be enough.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • [] This PR bumps the version.

@martijnvans martijnvans changed the title Testing: add retries for Windows ssh issues Testing: add retries for Windows Core ssh issues Nov 14, 2023
franciscovalentecastro
franciscovalentecastro approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvans martijnvans merged commit 1130dec into master Nov 20, 2023
69 checks passed
@martijnvans martijnvans deleted the martijnvans-retry-windows-ssh branch November 20, 2023 17:51
franciscovalentecastro pushed a commit that referenced this pull request Nov 21, 2023
@martijnvans @franciscovalentecastro
Testing: add retries for Windows Core ssh issues (#1514)
9132cb5
franciscovalentecastro pushed a commit that referenced this pull request Nov 21, 2023
@martijnvans @franciscovalentecastro
Testing: add retries for Windows Core ssh issues (#1514)
d6a056f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

@jefferbrecht jefferbrecht Awaiting requested review from jefferbrecht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martijnvans @franciscovalentecastro