Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rhel-8-1-sap-ha #1544

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Remove rhel-8-1-sap-ha #1544

merged 1 commit into from
Dec 13, 2023

Conversation

jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Dec 13, 2023 •
edited by igorpeshansky

Description

rhel-8-1-sap-ha is deprecated.

Related issue

b/315990795

How has this been tested?

Will let presubmits run, and then will try a release test afterwards.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

qingling128
qingling128 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

igorpeshansky
igorpeshansky reviewed Dec 13, 2023
View reviewed changes
integration_test/agents/agents.go Outdated Show resolved Hide resolved
integration_test/agents/agents.go Outdated Show resolved Hide resolved
@jefferbrecht
Remove rhel-8-1-sap-ha
2d8291b 
rhel-8-1-sap-ha is deprecated.
igorpeshansky
igorpeshansky approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jefferbrecht
Copy link
Member Author

RL8 tests are passing (modulo the GPU failures which are unrelated to this change); merging.

@jefferbrecht jefferbrecht merged commit 3706450 into master Dec 13, 2023
57 of 72 checks passed
@jefferbrecht jefferbrecht deleted the jefferbrecht-rhel-81-sap branch December 13, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jefferbrecht @qingling128 @igorpeshansky