Windows: Print all arguments passed to service #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were only printing the service start arguments (which we don't populate) and not the actual command-line arguments (which we do populate). Also remove a line that was printing garbage.
jefferbrecht
force-pushed
the
jefferbrecht-windows-args
branch
from
2d5f2a9
to
43630c4
Compare
|
Mix of presubmit errors, all seem to be unrelated to this change -- merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we were only printing the service start arguments (which we don't populate) and not the actual command-line arguments (which we do populate).
Also remove a line that was printing garbage.
Related issue
b/333974153
How has this been tested?
Will let presubmits run
Checklist: