Add (and use) ghproxy deployment #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fejta
approved these changes
Oct 11, 2019
|
/hold |
fejta
reviewed
Oct 11, 2019
There was a problem hiding this comment.
Can we please shrink the blast radius here? AKA
- pick one component to update to use ghproxy. that way when it doesn't work, only one component is not working instead of all of them
- Pick a component that will have the least user impact if there's github connectivity issues.
AKA hook is a terrible choice, deck or plank might be good ones as life will be better once we revert.
cjwagner
approved these changes
Oct 21, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, clarketm, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #101
/assign @cjwagner @fejta