Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable review_acts_as_lgtm for kpt-config-sync #2121

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

sdowell
Copy link
Contributor

@sdowell sdowell commented Nov 16, 2023

With the new request to require the Github UI approval button on our
repository, we've lost the ability to effectively approve a PR
without granting lgtm. Disabling review_acts_as_lgtm will enable an
approver to grant the approval state/label without granting lgtm.

Context:

GoogleContainerTools/kpt-config-sync#1002 Requested for us to require the Approval UI button, despite our usage of prow to manage lgtm/approval. There is a bit of redundancy now with the approval mechanisms, but this should allow us to separate approve from lgtm again.

With the new request to require the Github UI approval button on our
repository, we've lost the ability to effectively approve a PR
without granting lgtm. Disabling review_acts_as_lgtm will enable an
approver to grant the approval state/label without granting lgtm.
@sdowell
Copy link
Contributor Author

sdowell commented Nov 16, 2023

/assign @janetkuo

@janetkuo
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 16, 2023
@chaodaiG
Copy link
Member

this
/lgtm
but I'm not on the team any more so:
/assign @cjwagner

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bf9b87f into GoogleCloudPlatform:master Nov 20, 2023
5 checks passed
Copy link
Contributor

@sdowell: Updated the plugins configmap in namespace default at cluster default using the following files:

  • key plugins.yaml using file prow/oss/plugins.yaml

In response to this:

With the new request to require the Github UI approval button on our
repository, we've lost the ability to effectively approve a PR
without granting lgtm. Disabling review_acts_as_lgtm will enable an
approver to grant the approval state/label without granting lgtm.

Context:

GoogleContainerTools/kpt-config-sync#1002 Requested for us to require the Approval UI button, despite our usage of prow to manage lgtm/approval. There is a bit of redundancy now with the approval mechanisms, but this should allow us to separate approve from lgtm again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants