disable review_acts_as_lgtm for kpt-config-sync #2121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new request to require the Github UI approval button on our
repository, we've lost the ability to effectively approve a PR
without granting lgtm. Disabling review_acts_as_lgtm will enable an
approver to grant the approval state/label without granting lgtm.
Context:
GoogleContainerTools/kpt-config-sync#1002 Requested for us to require the Approval UI button, despite our usage of prow to manage lgtm/approval. There is a bit of redundancy now with the approval mechanisms, but this should allow us to separate approve from lgtm again.