Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require and report expected green KFP SDK tests #2127

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Nov 29, 2023

Removes the optional and skip_report flags (sets to false) all KFP SDK tests that we require to be green.

This includes requiring tests on Python 3.12 to be green. We validated that the Python 3.12 tests pass in kubeflow/pipelines#10272.

@connor-mccarthy
Copy link
Member Author

/assign @chensun
/hold

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 29, 2023
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

/unhold

@google-oss-prow google-oss-prow bot merged commit b1f77d0 into GoogleCloudPlatform:master Nov 30, 2023
6 checks passed
Copy link
Contributor

@connor-mccarthy: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubeflow-pipelines-presubmits.yaml using file prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml

In response to this:

Removes the optional and skip_report flags (sets to false) all KFP SDK tests that we require to be green.

This includes requiring tests on Python 3.12 to be green. We validated that the Python 3.12 tests pass in kubeflow/pipelines#10272.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants