Update dependency versions #271
Conversation
tmatsuo
commented
Dec 9, 2016
•
tmatsuo
commented
- google/cloud: ^0.20
- google/cloud-tools: ^0.6
There was a problem hiding this comment.
In general, I would prefer to have ^0.20, since the convention followed by google/cloud is to break BC on minor releases. This way, we would know for sure that all samples are on the same version. With the current syntax, one sample could be on 0.40 and another on 0.20.
Also, w/o commenting on every single one, I'd like to know why google/auth is added as a dependency.
| "paragonie/random_compat": " ^2.0", | ||
| "google/cloud-tools": "~0.6" | ||
| }, | ||
| "require": { |
There was a problem hiding this comment.
We can remove the empty require statement here.
| "paragonie/random_compat": " ^2.0", | ||
| "google/cloud-tools": "~0.6" | ||
| }, | ||
| "require": { |
There was a problem hiding this comment.
Remove empty require statement here!
| "symfony/console": "^3.0" | ||
| "google/cloud": "~0.20", | ||
| "symfony/console": "^3.0", | ||
| "google/auth": "~0.11" |
There was a problem hiding this comment.
Why are we adding the auth line? This should be left to the google/cloud library unless we are consuming the library directly (which we aren't).
There was a problem hiding this comment.
I added google/auth because I saw an error like this:
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for google/cloud ^0.20 -> satisfiable by google/cloud[v0.20.0].
- Conclusion: remove google/auth v0.10
- google/cloud v0.20.0 requires google/auth ^0.11 -> satisfiable by google/auth[v0.11.0, v0.11.1].
- Can only install one of: google/auth[v0.11.0, v0.10].
- Can only install one of: google/auth[v0.11.1, v0.10].
- Installation request for google/auth (installed at v0.10) -> satisfiable by google/auth[v0.10].
in some sub directories, but you're right
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "require": { | |||
| "php": ">=5.4", | |||
| "google/cloud": "0.10" | |||
| "google/cloud": "~0.20", | |||
| "google/auth": "~0.11" | |||
There was a problem hiding this comment.
Same here, we can leave this out.
tmatsuo
force-pushed
the
version-update
branch
from
9169e7f
to
75628ec
Compare
|
@bshaffer PTAL |
|
Finally the test passes. @bshaffer PTAL |
