properly skip datastore tests from other repos #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
reviewed
Dec 13, 2016
| @@ -25,6 +25,9 @@ public function setUp() | |||
| if (!getenv('GCLOUD_PROJECT')) { | |||
| $this->markTestSkipped('Must set GCLOUD_PROJECT'); | |||
| } | |||
| if (!getenv('GOOGLE_APPLICATION_CREDENTIALS')) { | |||
There was a problem hiding this comment.
GOOGLE_APPLICATION_CREDENTIALS is actually set in the .travis.yaml so it doesn't skip. I think you need to check the file existence.
|
|
|
@tmatsuo I added Also I disagree, I think checking if the file exists is a pain because it's an additional check. |
|
We could possibly add the |
|
Closing for now, we'll find a better way to do this. |
SurferJeffAtGoogle
pushed a commit
to SurferJeffAtGoogle/php-docs-samples
that referenced
this pull request
May 15, 2017
GoogleCloudPlatform#260) * updates all samples for google/cloud-tools and adds delay to endpoints * uses google/cloud 0.12 because of issue GoogleCloudPlatform#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this is from my fork, to test it works