Skip to content

Commit

Permalink
fix: make sure tests are not failing on cloudtop (#1025)
Browse files Browse the repository at this point in the history
Turns out @TheSpiritXIII
[suggestion](#1021 (comment))
was worth doing 馃檭
  • Loading branch information
bwplotka committed Jun 12, 2024
2 parents 054f28c + a1ed6ac commit 1df4974
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions pkg/export/setup/setup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
func TestFromFlags_NotOnGCE(t *testing.T) {
// Asserting there is actually no GCE underneath.
if metadata.OnGCE() {
t.Fatal("This test assumes we don't run on GCP")
t.Skip("This test can't run on GCP or Cloudtop; we expect no metadata server.")
}

fake := kingpin.New("test", "test")
Expand All @@ -53,11 +53,6 @@ func TestFromFlags_NotOnGCE(t *testing.T) {
// Regression test for b/344740239. We ensure that even stuck metadata servers
// calls will timeout correctly (we propagate context properly).
func TestTryPopulateUnspecifiedFromMetadata(t *testing.T) {
// Asserting there is actually no GCE underneath.
if metadata.OnGCE() {
t.Fatal("This test assumes we don't run on GCP")
}

var wg sync.WaitGroup
wg.Add(1)

Expand Down

0 comments on commit 1df4974

Please sign in to comment.