Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the GitHub Actions file for prombench. #68

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

saketjajoo
Copy link
Member

This commit adds the GitHub Actions file to trigger the benchmarking process for GMP Collector (using the prombench tool).

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! Thanks!

Let's merge and iterate 💪🏽

@bwplotka
Copy link
Collaborator

bwplotka commented Jul 7, 2023

I can only rebase & merge
image

Probably by design? @TheSpiritXIII

@bwplotka
Copy link
Collaborator

bwplotka commented Jul 7, 2023

Let's rebase this PR to one commit (I don't think we want two, where second is a small fix) or we enable squash merge and merge 🤔

This commit adds the GitHub Actions file to trigger the benchmarking
process for GMP Collector (using the prombench tool).

Signed-off-by: saketjajoo <saketjajoo77@gmail.com>

Updating the default permissions for GITHUB_TOKEN and setting the COMMENTER as an env variable.

Signed-off-by: saketjajoo <saketjajoo77@gmail.com>
@bwplotka
Copy link
Collaborator

bwplotka commented Jul 7, 2023

Cancelled lint as it passed before and we just squashed. Plus lint does not lint yaml file we are just adding.

@bwplotka bwplotka merged commit 6b0775b into release-2.35.0-gmp Jul 7, 2023
1 of 2 checks passed
@bwplotka bwplotka deleted the prombench-gh-actions branch July 7, 2023 15:55
@saketjajoo saketjajoo added the prombench This is meant for labeling everything related to prombench. label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prombench This is meant for labeling everything related to prombench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants