Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create RECORD when it would have no fields #8

Merged
merged 4 commits into from Feb 5, 2018
Merged

don't create RECORD when it would have no fields #8

merged 4 commits into from Feb 5, 2018

Conversation

dmccartney
Copy link
Contributor

given a proto like

message FooTable {
  option (gen_bq_schema.table_name) = "foo_table";
  string foo_field_a = 1;
  EmptyFooField foo_field_b = 2;
}

message EmptyFooField {
}

the plugin would produce an invalid schema:

...
{"name":"foo_field_b","type":"RECORD","mode":"NULLABLE"},
...

-> BigQuery error in mk operation: Field foo_field_b is type RECORD but has no schema

So this PR discards any RECORD that would have no fields.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@dmccartney
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@yugui
Copy link
Collaborator

yugui commented Feb 5, 2018

LGTM. Thank you for your contribution.

@yugui yugui merged commit 481d6bb into GoogleCloudPlatform:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants