Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a dataset's Terraform files into their own folder #2

Merged
merged 5 commits into from Apr 26, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Apr 19, 2021

Based on #1 , we move a dataset's Terraform files in its own folder so it's more organized.

This also makes it more intuitive what directory to cd into to perform the resource actuation (i.e. terraform apply)

Checklist

  • Tests pass.
  • Linters pass.
  • Please merge this PR for me once it is approved.
  • If this PR adds/edits/deletes a feature, I have updated the README accordingly.

@adlersantos adlersantos requested a review from tswast April 19, 2021 21:06
@adlersantos adlersantos added the cleanup Cleanup or refactor code label Apr 19, 2021
@adlersantos adlersantos self-assigned this Apr 21, 2021
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@adlersantos adlersantos merged commit 73141df into main Apr 26, 2021
@adlersantos adlersantos deleted the tf-folder branch April 26, 2021 18:55
gkodukula added a commit to gkodukula/public-datasets-pipelines that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup or refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants