Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removed unecessary pathlib param from test_deploy_dag #345

Merged
merged 1 commit into from
May 2, 2022
Merged

chore: Removed unecessary pathlib param from test_deploy_dag #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/scripts/test_deploy_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ def test_script_with_pipeline_arg_deploys_only_that_pipeline(
def test_script_with_pipeline_arg_deploys_without_gcs_bucket_param(
dataset_path: pathlib.Path,
pipeline_path: pathlib.Path,
pipeline_path_2: pathlib.Path,
env: str,
mocker,
):
Expand All @@ -384,7 +383,7 @@ def test_script_with_pipeline_arg_deploys_without_gcs_bucket_param(
deploy_dag.main(
env_path=ENV_PATH,
dataset_id=dataset_path.name,
pipeline=pipeline_path_2.name,
pipeline=pipeline_path.name,
composer_env="test-env",
composer_bucket=None,
composer_region="test-region",
Expand Down