Feat: Onboard New York Taxi Trips dataset #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adlersantos Please review! Thanks. |
adlersantos
reviewed
Jun 16, 2022
datasets/new_york_taxi_trips/pipelines/new_york_taxi_trips/pipeline.yaml
Outdated
Show resolved
Hide resolved
adlersantos
reviewed
Jun 16, 2022
datasets/new_york_taxi_trips/pipelines/new_york_taxi_trips/pipeline.yaml
Outdated
Show resolved
Hide resolved
adlersantos
reviewed
Jun 16, 2022
datasets/new_york_taxi_trips/pipelines/new_york_taxi_trips/pipeline.yaml
Outdated
Show resolved
Hide resolved
adlersantos
approved these changes
Jun 16, 2022
| @@ -0,0 +1,34 @@ | |||
| /** | |||
There was a problem hiding this comment.
This whole file should be gone.
| @@ -0,0 +1,34 @@ | |||
| /** | |||
There was a problem hiding this comment.
This one too should be gone. So all *_pipeline.tf files must be replaced by the new_york_taxi_trips_pipeline.tf file.
adlersantos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g.
datasets/google_trendsResubmitted because of loss of my original fork.
Note: If an item applies to you, all of its sub-items must be fulfilled
datasets/new_york_taxi_tripsand nothing outside of that directory