Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Kafka headers to PubSub attributes #200

Merged
merged 6 commits into from
Jun 17, 2019
Merged

Copy Kafka headers to PubSub attributes #200

merged 6 commits into from
Jun 17, 2019

Conversation

cyanezp
Copy link
Contributor

@cyanezp cyanezp commented Apr 10, 2019

Same as previous failed attempt, I'm generating this pull request to allow to copy Kafka attributes to PubSub headers (like PR #195)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@cyanezp cyanezp mentioned this pull request Apr 11, 2019
Closed
@kamalaboulhosn kamalaboulhosn self-requested a review April 18, 2019 14:06
kamalaboulhosn
kamalaboulhosn requested changes Apr 18, 2019
View reviewed changes
Copy link
Collaborator

@kamalaboulhosn kamalaboulhosn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change in terms of adding support for headers. Just a few comments/clarifications and some changes that may need to be made. Thanks!

kafka-connector/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkTask.java Show resolved Hide resolved
kafka-connector/src/main/java/com/google/pubsub/kafka/source/CloudPubSubSourceTask.java Show resolved Hide resolved
cyanezp and others added 2 commits May 20, 2019 15:07
@cyanezp
* Restored backwards compatibility for CloudPubSubSourceTask when pro…
e28b29f 
…cesing PubSub attributes so they can be stored within a Kafka structure or record headers.

* Apply a filter on CloudPubSubSinkTask when publishing PubSub attributes to exclude those who are not compatible due to Pubsub limitations.
* Updated README to reflect this changes.
* Updated unit tests.
@cyanezp
Merge branch 'master' into master
0ac5552
@kamalaboulhosn
Copy link
Collaborator

Sorry for the delay in looking at this. I have verified the CLA checks manually and will merge. Thanks for the improvements!

@kamalaboulhosn kamalaboulhosn merged commit c8d7a0a into GoogleCloudPlatform:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyanezp @googlebot @kamalaboulhosn @gh-mlfowler