add a filter to allow state = DONE

GoogleCloudPlatform · Apr 17, 2020 · eccd521 · eccd521
1 parent bb009db
commit eccd521
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 23 deletions.
diff --git a/dlp/jobs_test.py b/dlp/jobs_test.py
@@ -15,7 +15,6 @@
 import os
 import uuid
 
-import backoff
 import pytest
 
 import jobs
@@ -62,31 +61,21 @@ def test_job_name():
 
 
 def test_list_dlp_jobs(test_job_name, capsys):
-    @backoff.on_exception(backoff.expo,
-                          AssertionError,
-                          max_time=60)
-    def test_real():
-        jobs.list_dlp_jobs(GCLOUD_PROJECT)
+    jobs.list_dlp_jobs(GCLOUD_PROJECT)
 
-        out, _ = capsys.readouterr()
-        assert test_job_name not in out
-    test_real()
+    out, _ = capsys.readouterr()
+    assert test_job_name not in out
 
 
 def test_list_dlp_jobs_with_filter(test_job_name, capsys):
-    @backoff.on_exception(backoff.expo,
-                          AssertionError,
-                          max_time=60)
-    def test_real():
-        jobs.list_dlp_jobs(
-            GCLOUD_PROJECT,
-            filter_string="state=RUNNING",
-            job_type="RISK_ANALYSIS_JOB",
-        )
-
-        out, _ = capsys.readouterr()
-        assert test_job_name in out
-    test_real()
+    jobs.list_dlp_jobs(
+        GCLOUD_PROJECT,
+        filter_string="state=RUNNING OR state=DONE",
+        job_type="RISK_ANALYSIS_JOB",
+    )
+
+    out, _ = capsys.readouterr()
+    assert test_job_name in out
 
 
 def test_list_dlp_jobs_with_job_type(test_job_name, capsys):

diff --git a/dlp/requirements-test.txt b/dlp/requirements-test.txt
@@ -1,4 +1,4 @@
 pytest==5.3.2
 flaky==3.6.1
 mock==3.0.5
-backoff==1.10.0
+