-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bigtable.snippets.writes.writes_test: test_writes failed #3070
Comments
Test passed in build 63e99d6 (Build Status, Sponge)! Closing this issue. |
Looks like this issue is flaky. 😟 I'm going to leave this open and stop commenting. A human should fix and close this. commit: ae464b1 |
From the log @billyjacobson Does it make sense to update the sample to handle this error and retry few times? If not, maybe we should wrap the each sample invocation with retries. Because now test_writes has 4 consecutive sample invocation. When the server is little bit flaky, the success rate of the test is significantly lowered. Let's say, the rpc success rate is 0.9. Then the success rate of What if we retry this test 3 times? The success rate will be: However, if we wrap these sample invocations with 3 times retry, the success rate of a single sample will be: The success rate of the whole test will be: It's significantly higher. |
fix GoogleCloudPlatform#3070 Also added `BIGTABLE_INSTANCE` to testing/test-env.tmpl.sh
fix #3070 Also added `BIGTABLE_INSTANCE` to testing/test-env.tmpl.sh
This test failed!
To configure my behavior, see the Build Cop Bot documentation.
If I'm commenting on this issue too often, add the
buildcop: quiet
label andI will stop commenting.
buildID: fadb04c
buildURL: Build Status, Sponge
status: failed
The text was updated successfully, but these errors were encountered: