Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to list assets from Organizations and Folders along with Projects #9641

Closed
shashyajoshi opened this issue Apr 15, 2023 · 0 comments · May be fixed by #9646
Closed

Add ability to list assets from Organizations and Folders along with Projects #9641

shashyajoshi opened this issue Apr 15, 2023 · 0 comments · May be fixed by #9646
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shashyajoshi
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

The issue you're having must be related to a file in this repository. We are unable to provide assistance for issues unrelated to samples in this repository.

Please include as much information as possible:

Is your feature request related to a problem? Please describe.

Current code accepts only projects as "parent" for the Asset API, whereas the API can list assets from Orgs and Folders as well. A small change to accept the other two options for "parent" will make the code more useful. Many people use Asset API to search for resources across multiple projects.

Describe the solution you'd like.

The current code at samples/snippets/quickstart_listassets.py has project_id as an argument, instead we can have parent_resource as an argument, and the parent_resource can be either projects/ or folders/ or organizations/. We then can change references to project_id with parent_resource in other places.

Describe alternatives you've considered.

Additional context.

(https://cloud.google.com/asset-inventory/docs/reference/rest/v1/assets/list#path-parameters)

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

@shashyajoshi shashyajoshi added priority: p3 Desirable enhancement or fix. May not be included in next release. triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 15, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
2 participants