quickstart list assets from Org & Folders #9646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code accepts only projects as "parent" for the Asset API, whereas the API can list assets from Orgs and Folders as well. A small change to accept the other two options for "parent" will make the code more useful. Many people use Asset API to search for resources across multiple projects. The current code at has `project_id` as an argument, instead we can have `parent_resource` as an argument, and the `parent_resource` can be either projects/ or folders/ or organizations/. We then can change references to `project_id` with `parent_resource` in other places.
product-auto-label
bot
added
samples
dandhlee
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
|
@shashyajoshi please consider changing this to draft status, until tests are passing. Then we can seek reviews. Thanks for your contribution! |
|
@shashyajoshi - checking to know if there are any new update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code accepts only projects as "parent" for the Asset API, whereas the API can list assets from Orgs and Folders as well. A small change to accept the other two options for "parent" will make the code more useful. Many people use Asset API to search for resources across multiple projects.
The current code at has
project_idas an argument, instead we can haveparent_resourceas an argument, and theparent_resourcecan be either projects/ or folders/ or organizations/. We then can change references toproject_idwithparent_resourcein other places.Description
Fixes #9641
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)