Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Imagen): Add python sdk samples for Multimodal Embeddings #10267

Merged
merged 14 commits into from
Feb 22, 2024

Conversation

yil532
Copy link
Member

@yil532 yil532 commented Jun 17, 2023

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 17, 2023
@yil532 yil532 requested a review from gericdong June 20, 2023 17:08
@yil532 yil532 marked this pull request as ready for review August 3, 2023 23:52
@yil532 yil532 requested review from a team as code owners August 3, 2023 23:52
@snippet-bot
Copy link

snippet-bot bot commented Aug 3, 2023

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yil532
Copy link
Member Author

yil532 commented Aug 4, 2023

Weird error, only failed in Python 3.11 and 3.8

@m-strzelczyk
Copy link
Contributor

Weird error, only failed in Python 3.11 and 3.8

It's not really weird, as right now, we're testing only versions 3.8 and 3.11 by default. I'm afraid there's a problems with your code.

You get an error ModuleNotFoundError: No module named 'google.cloud.aiplatform.private_preview' - I guess you need to update the requirements.txt file.

generative_ai/text_embedding.py Outdated Show resolved Hide resolved
generative_ai/text_image_embedding.py Outdated Show resolved Hide resolved
@yil532 yil532 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2023
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2023
@m-strzelczyk
Copy link
Contributor

If I understand correctly, we're waiting for module publication, so I will turn this PR to draft for now. Please change it back when the module is public.

@m-strzelczyk m-strzelczyk marked this pull request as draft September 28, 2023 14:20
@yil532
Copy link
Member Author

yil532 commented Oct 17, 2023

I just checked, it's still under private preview. I will leave it until the preview/GA launch.

@yil532
Copy link
Member Author

yil532 commented Oct 17, 2023

Reassign to Eric to keep track of the status.

@holtskinner holtskinner changed the title feat(Imagen): Add python sdk samples for Imagen API feat(Imagen): Add python sdk samples for Multimodal Embeddings Feb 20, 2024
@holtskinner holtskinner marked this pull request as ready for review February 20, 2024 21:30
@holtskinner
Copy link
Contributor

Ready for review - Only test failures are from other code samples (not edited in this PR)

@gericdong
Copy link
Contributor

Note that the errors in the CI tests are not relevant to this PR.

@m-strzelczyk m-strzelczyk merged commit f93e2e0 into main Feb 22, 2024
10 of 12 checks passed
@m-strzelczyk m-strzelczyk deleted the yvonne-imagen-api branch February 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants