-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code sample for generative-ai/function-calling
to include API response and model summary response from Gemini
#11254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Feb 26, 2024
FYI, tests are failing for other code samples, but this particular code sample looks to be passing. |
m-strzelczyk
requested changes
Feb 27, 2024
@m-strzelczyk, thanks for the review! I've updated the sample code with the changes that you mentioned. |
m-strzelczyk
approved these changes
Feb 27, 2024
Thanks for approving! @m-strzelczyk, could you or someone help me merge this since the CI tests are failing and I'm unable to merge? I confirmed that this PR is passing CI tests in the latest run. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11253.
Updates the sample code and tests for
generative-ai/function-calling
with a mock API response and returning this data to Gemini via thePart.from_function_response()
to show a full end-to-end example of function calling, including the model summary response.Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)These samples need a new API enabled in testing projects to pass (let us know which ones)These samples need a new/updated env vars in testing projects set to pass (let us know which ones)This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sampleThis sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample