Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code sample for generative-ai/function-calling to include API response and model summary response from Gemini #11254

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

koverholt
Copy link
Member

@koverholt koverholt commented Feb 26, 2024

Description

Fixes #11253.

Updates the sample code and tests for generative-ai/function-calling with a mock API response and returning this data to Gemini via the Part.from_function_response() to show a full end-to-end example of function calling, including the model summary response.

Checklist

@koverholt
Copy link
Member Author

FYI, tests are failing for other code samples, but this particular code sample looks to be passing.

generative_ai/function_calling.py Outdated Show resolved Hide resolved
generative_ai/function_calling.py Outdated Show resolved Hide resolved
generative_ai/function_calling.py Outdated Show resolved Hide resolved
@koverholt
Copy link
Member Author

@m-strzelczyk, thanks for the review! I've updated the sample code with the changes that you mentioned.

@koverholt
Copy link
Member Author

Thanks for approving! @m-strzelczyk, could you or someone help me merge this since the CI tests are failing and I'm unable to merge? I confirmed that this PR is passing CI tests in the latest run.

@m-strzelczyk m-strzelczyk merged commit a585e56 into main Feb 27, 2024
10 of 12 checks passed
@m-strzelczyk m-strzelczyk deleted the generative-ai-function-calling-updates branch February 27, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
2 participants