Make TODO clearer what action to take. #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe the variables to set explicitly (rather than "this"), as suggested in internal CL 227863277.
googlebot
added
the
cla: yes
alixhami
reviewed
Jan 8, 2019
alixhami
reviewed
Jan 8, 2019
alixhami
approved these changes
Jan 8, 2019
plamut
pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jun 25, 2020
…python-docs-samples#1963) * Make TODO clearer what action to take. Describe the variables to set explicitly (rather than "this"), as suggested in internal CL 227863277. * Use standard 'uncomment the variable below' for TODO * Move variable below TODO.
plamut
pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jul 22, 2020
…python-docs-samples#1963) * Make TODO clearer what action to take. Describe the variables to set explicitly (rather than "this"), as suggested in internal CL 227863277. * Use standard 'uncomment the variable below' for TODO * Move variable below TODO.
shollyman
pushed a commit
to googleapis/python-bigquery
that referenced
this pull request
Jul 22, 2020
…python-docs-samples#1963) * Make TODO clearer what action to take. Describe the variables to set explicitly (rather than "this"), as suggested in internal CL 227863277. * Use standard 'uncomment the variable below' for TODO * Move variable below TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the variables to set explicitly (rather than "this"), as
suggested in internal CL 227863277.