Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New library version to address failure. #2057

Merged
merged 7 commits into from
Mar 19, 2019
Merged

New library version to address failure. #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6a9b2d6
New library version to address failure.
engelke Mar 18, 2019
cf27412
Encoded strings for library call
engelke Mar 18, 2019
a78fa25
Give changes a bit longer to finish
engelke Mar 18, 2019
664de88
fix lint error
crwilcox Mar 19, 2019
9e9eafa
Update main.py
crwilcox Mar 19, 2019
9ef1cb2
Paren was missing
engelke Mar 19, 2019
4ffbb0b
Merge branch 'master' into happybase_version
engelke Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion bigtable/hello_happybase/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ def main(project_id, instance_id, table_name):
#
# https://cloud.google.com/bigtable/docs/schema-design
row_key = 'greeting{}'.format(i)
table.put(row_key, {column_name: value})
table.put(
row_key, {column_name.encode('utf-8'): value.encode('utf-8')}
)
# [END writing_rows]

# [START getting_a_row]
Expand Down
2 changes: 1 addition & 1 deletion bigtable/hello_happybase/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
google-cloud-happybase==0.32.1
google-cloud-happybase==0.33.0
4 changes: 2 additions & 2 deletions bigtable/metricscaler/metricscaler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ def test_scale_bigtable():

scale_bigtable(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, True)

time.sleep(3)
time.sleep(10)
cluster.reload()

new_node_count = cluster.serve_nodes
assert (new_node_count == (original_node_count + SIZE_CHANGE_STEP))

scale_bigtable(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, False)
time.sleep(3)
time.sleep(10)
cluster.reload()
final_node_count = cluster.serve_nodes
assert final_node_count == original_node_count
Expand Down