Move in ndb queries code snippets & tests #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jerjou
force-pushed
the
ndb-queries
branch
3 times, most recently
from
3b57028
to
1af9a59
Compare
|
|
||
|
|
||
| class Greeting(ndb.Model): | ||
| '''Models an individual Guestbook entry with content and date.''' |
There was a problem hiding this comment.
should be double quotes for docstrings
|
minor nits to consider, overall lgtm, nice tests |
jerjou
force-pushed
the
ndb-queries
branch
2 times, most recently
from
b28da9d
to
91065a3
Compare
|
rebased on master. Will merge when travis gives the okay. |
nicain
pushed a commit
that referenced
this pull request
Nov 2, 2022
8 tasks
xtineskim
pushed a commit
that referenced
this pull request
Nov 11, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 14, 2022
Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
8 tasks
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Dec 2, 2022
* fix: fix path to products files. * Fix path creation. Move gcs bucket creation logic to the function. Co-authored-by: nicain <nicholascain@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Dec 2, 2022
* fix: fix path to products files. * Fix path creation. Move gcs bucket creation logic to the function. Co-authored-by: nicain <nicholascain@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
holtskinner
pushed a commit
that referenced
this pull request
Jan 3, 2023
8 tasks
holtskinner
pushed a commit
that referenced
this pull request
Jan 4, 2023
dandhlee
pushed a commit
that referenced
this pull request
Jan 5, 2023
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.