-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kms] fix: use unique ids for test #3563
Merged
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
approved these changes
Apr 27, 2020
gguuss
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test failure is about quota per projects. We'll need to use multiple project for mitigate that.
I'm going to rebuild and merge. |
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 4, 2020
…on-docs-samples#3563) fixes #3554 fixes #3555
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3554
fixes #3555
It might fix the above issues.