Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing cloud speech code samples to work with v1beta1 #399

Merged
merged 4 commits into from
Jul 1, 2016
Merged

Changing cloud speech code samples to work with v1beta1 #399

merged 4 commits into from
Jul 1, 2016

Conversation

xinjiez
Copy link
Contributor

@xinjiez xinjiez commented Jul 1, 2016

This is adapted from alpha samples in speech/api.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2016
@xinjiez xinjiez changed the title Adding v1beta1 cloud speech code samples Changing cloud speech code samples to work with v1beta1 Jul 1, 2016
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 1, 2016
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 1, 2016
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 1, 2016
@theacodes
Copy link
Contributor

This LGTM. I made some small changes for style, can you confirm it still works?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@theacodes theacodes merged commit bfef34d into GoogleCloudPlatform:master Jul 1, 2016
theacodes pushed a commit that referenced this pull request Jul 6, 2016
Revert "Changing cloud speech code samples to work with v1beta1 (#399)"
43c8ec6 
This reverts commit bfef34d.
theacodes pushed a commit that referenced this pull request Jul 13, 2016
Revert "Revert "Changing cloud speech code samples to work with v1bet…
7bb6b01 
…a1 (#399)""

This reverts commit 43c8ec6.

Change-Id: I9ac6b22de52d413c480f5af750e53a46a0157c6c
jerjou
jerjou reviewed Jul 13, 2016
View reviewed changes
speech/api/speech_gcs.py
if __name__ == '__main__':
parser = argparse.ArgumentParser()
parser.add_argument('input_uri', type=_gcs_uri)
parser.add_argument('output_uri', type=_gcs_uri)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point of this sample was to demonstrate having an output uri on gcs (thus '_gcs' in the filename). Is that not supported anymore?

@xinjiez
Copy link
Contributor Author

xinjiez commented Jul 13, 2016

That's not supported any more in v1beta1. I think I also changed the file name to speech_grpc to repurpose it to demo grpc instead.

msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
@renovate-bot
chore(deps): update all dependencies (#399)
5fce912
@msampathkumar msampathkumar mentioned this pull request Nov 14, 2022
Merged
8 tasks
engelke pushed a commit that referenced this pull request Nov 28, 2022
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3 (#399)
ee3e9b1
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
@renovate-bot @dandhlee
chore(deps): update dependency google-cloud-bigquery to v3 (#399)
80ccf32
holtskinner pushed a commit that referenced this pull request Jan 3, 2023
@renovate-bot @holtskinner
chore(deps): update dependency google-cloud-storage to v2.6.0 (#399)
4356d33
@holtskinner holtskinner mentioned this pull request Jan 4, 2023
Merged
8 tasks
holtskinner pushed a commit that referenced this pull request Jan 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2.6.0 (#399)
b82b31b
dandhlee pushed a commit that referenced this pull request Jan 5, 2023
@renovate-bot @dandhlee
chore(deps): update dependency google-cloud-storage to v2.6.0 (#399)
ae626b1
dizcology pushed a commit that referenced this pull request Jun 16, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
9c040dd 
…v3.7.2 (#399)
@dizcology dizcology mentioned this pull request Jun 16, 2023
Merged
9 tasks
dizcology pushed a commit that referenced this pull request Jul 10, 2023
@renovate-bot @dizcology
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
f6ed45b 
…v3.7.2 (#399)
leahecole pushed a commit that referenced this pull request Jul 11, 2023
@renovate-bot @leahecole
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
11294c1 
…v3.7.2 (#399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xinjiez @theacodes @googlebot @jerjou