Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme fixes #415

Closed
wants to merge 4 commits into from
Closed

Readme fixes #415

wants to merge 4 commits into from

Conversation

puneith
Copy link
Contributor

@puneith puneith commented Jul 13, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 13, 2016
@danaharon
Copy link
Contributor

can you remove "The sample uses the PyAudio library to stream audio from your computer's microphone. PyAudio depends on PortAudio, which may need to be compiled when you install PyAudio." and instead add PortAudio + PyAudio to the section next to pip, gcloud?

@puneith
Copy link
Contributor Author

puneith commented Jul 13, 2016

@jonparrott please take a look. Need help to make sure this looks appropriate. Please, don't merge though.


* If you're running the `speech_rest.py` sample:

```sh
$ sudo pip install -r requirements-speech_rest.txt
$ sudo pip install -r requirements-speech_rest.txt --ignore-installed six
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use sudo, don't ignore installed six, just tell them to use virtualenv.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been thinking about that as well. virtual env or conda. But, the problem is what if they want to do something outside of virtual?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

virtual / conda makes life so much easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then that's up to them. Virtualenv isn't a controversial recommendation. It's broadly used, and recommended by every other sample here.

@theacodes theacodes self-assigned this Jul 13, 2016
@puneith puneith closed this Jul 14, 2016
@puneith puneith deleted the readme-fixes branch July 14, 2016 04:21
arbrown pushed a commit that referenced this pull request Nov 17, 2022
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this pull request Nov 17, 2022
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants