-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudsql): add MySQL Auto IAM AuthN sample #8526
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you be adding tests once unblocked?
I looked into it and I believe there isn't a major value add for the additional test (not worth the additional testing resources being spun up). This feature is only a slight variation of connect_connector.py (additional flag being set) which already is tested as part of connector_test. @dandhlee Because of this I think it is okay to continue without a test for this addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, discussed offline that the features are tested from the client library and this sample in general (connect
/ create_engine
) are tested.
Adding code sample for MySQL's automatic IAM Authentication feature that will be rolling out soon.
Blocked on #466