Add support for using Ubuntu 16 as a base instead of Debian 8 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2018 13:31
Also, change --local to use the official gcloud tool instead of our own.
Contains various bugfixes and security patches. We switch from using the Debian-provided "python3.4" packages to building it from source, in preparation for moving to newer OS base images that don't have a prebuilt Python 3.4 interpreter available.
|
Not ready for review, despite what GitHub thinks :) |
duggelz
changed the title
|
Ready for review |
liyanhui1228
approved these changes
Mar 13, 2018
build.sh
Outdated
| @@ -137,7 +149,11 @@ if [ "${local}" -eq 1 ]; then | |||
| fi | |||
|
|
|||
| # Use latest released Debian as our base image | |||
build.sh
Outdated
| @@ -137,7 +149,11 @@ if [ "${local}" -eq 1 ]; then | |||
| fi | |||
|
|
|||
| # Use latest released Debian as our base image | |||
| export DEBIAN_BASE_IMAGE="gcr.io/google-appengine/debian8:latest" | |||
| if [ "${os_base}" == "ubuntu16" ]; then | |||
| export DEBIAN_BASE_IMAGE="gcr.io/gcp-runtimes/ubuntu_16_0_4:latest" | |||
There was a problem hiding this comment.
Maybe change the variable name to BASE_IMAGE as it could be either debian or ubuntu?
There was a problem hiding this comment.
Renamed to OS_BASE_IMAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires building Python 3.4 from source, so we do that.
Future changes may add support for other OS base images, such as Debian 9 and Ubuntu 18. We don't support arbitrary OS base images in general, so it's an enumerated list.